Skip to content

[channels] Relax django-stubs dependency#15524

Merged
srittau merged 1 commit intopython:mainfrom
hartungstenio:relax-channels
Mar 20, 2026
Merged

[channels] Relax django-stubs dependency#15524
srittau merged 1 commit intopython:mainfrom
hartungstenio:relax-channels

Conversation

@hartungstenio
Copy link
Contributor

@hartungstenio hartungstenio commented Mar 18, 2026

Hello. This is my first contribution to typeshed — happy to receive any feedback!

Relaxes the django-stubs version constraint in the channels stub to align with the django dependency declared on the channels package..

Fixes #15523

@srittau
Copy link
Collaborator

srittau commented Mar 18, 2026

I don't know why pre-commit fails. I'd put it down to a temporary outage for now.

@hartungstenio hartungstenio marked this pull request as ready for review March 18, 2026 19:29
@huynguyengl99
Copy link
Contributor

Looks good to me. Hope we can somehow re-run the pre-commit (or verify it locally) so that we can make sure it won't break the code when being merged to the main branch. (although nothing wrong with that)

@hartungstenio
Copy link
Contributor Author

@huynguyengl99 @srittau The main branch seems to be already broken with the same pre-commit issue.

@brianschubert
Copy link
Collaborator

pre-commit.ci run

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 8193aa1 into python:main Mar 20, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

channels: relax django-stubs dependency

4 participants